Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puller: fix retry logic when check store version failed (#11903) #11931

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11903

What problem does this PR solve?

Issue Number: close #11766

What is changed and how it works?

Change the retry logic to reload region when client.GetStore failed.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix the problem that changefeed may get stuck after scaling out new tikv nodes.

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 67.56757% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@cd5e9e4). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 61.8527% <0.0000%> (?)
dm 51.0650% <0.0000%> (?)
engine 63.4444% <0.0000%> (?)
Flag Coverage Δ
unit 57.4490% <67.5675%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #11931   +/-   ##
================================================
  Coverage               ?   57.4490%           
================================================
  Files                  ?        854           
  Lines                  ?     126110           
  Branches               ?          0           
================================================
  Hits                   ?      72449           
  Misses                 ?      48263           
  Partials               ?       5398           

@lidezhu
Copy link
Collaborator

lidezhu commented Dec 24, 2024

/retest

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 30, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 30, 2024
@lidezhu
Copy link
Collaborator

lidezhu commented Dec 30, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 6cd1c19 into pingcap:release-8.1 Dec 30, 2024
27 checks passed
@lidezhu lidezhu deleted the cherry-pick-11903-to-release-8.1 branch December 30, 2024 17:16
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2025

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-storage-test e434beb link unknown /test cdc-integration-storage-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants